compact: add log for keyCompactions when finished compaction #18516
Conversation
|
Hi @qsyqian. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18516 +/- ##
==========================================
+ Coverage 68.77% 68.81% +0.03%
==========================================
Files 420 420
Lines 35535 35536 +1
==========================================
+ Hits 24440 24453 +13
+ Misses 9660 9654 -6
+ Partials 1435 1429 -6 Continue to review full report in Codecov by Sentry.
|
|
/ok-to-test |
qsyqian
force-pushed
the
add_log_keycompactions
branch
from
e8a02bd
to
266270c
Compare
|
@qsyqian please rebase this PR, which should be able to fix the |
Signed-off-by: qsyqian <[email protected]>
qsyqian
force-pushed
the
add_log_keycompactions
branch
from
266270c
to
7fb484c
Compare
|
/retest |
|
/test pull-etcd-integration-1-cpu-amd64 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, qsyqian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
add more log for debug #18509
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.